Add custom headers to smart http requests

[spraints]

This integrates libgit2/libgit2#3411 into rugged.

[arthurschreiber]

@spraints Cool stuff!

As-is, this is going to leak memory on every call. You need call git_strarray_free() after you're done with the git_strarray struct.

You need to do something like this:

static VALUE rb_git_remote_extra_http_headers(VALUE self)
{
    git_remote *remote;
    git_strarray http_headers;
    VALUE rb_result;


    Data_Get_Struct(self, git_remote, remote);

    rugged_exception_check(
        git_remote_extra_http_headers(remote, &http_headers)
    );

    rb_result = rugged_strarray_to_rb_ary(&http_headers);
    git_strarray_free(&http_headers);

    return rb_result;
}

[spraints]

As-is, this is going to leak memory on every call. You need call git_strarray_free() after you're done with the git_strarray struct.

Ah, cool. Good catch. libgit2/libgit2#3411 needs some more iteration. When that's more settled, I'll come back to this.

[arthurschreiber]

You can move this declaration inside the if block.

[spraints]

You can move this declaration inside the if block.

1324d66

[arthurschreiber]

Looking great. 👍

[arthurschreiber]

@spraints Can you bump libgit2 and squash the other commits so this can be merged?

[spraints]

Can you bump libgit2 and squash the other commits so this can be merged?

Yep! fde2448 is squashed with an updated libgit2. 😀

Looking at the diff now, it looks like I could add support for custom fetch headers too. IIRC, I added that to libgit2/libgit2#3411, but it isn't here. Would you like me to do that?

[spraints]

Looking at the diff now, it looks like I could add support for custom fetch headers too. IIRC, I added that to libgit2/libgit2#3411, but it isn't here. Would you like me to do that?

2f1f02d adds custom headers in more places. If it looks good, I can squash again.

[arthurschreiber]

Oh, good catch with freeing of the strarray objects. Everything LGTM!

[spraints]

Oh, good catch with freeing of the strarray objects. Everything LGTM!

🤘 It's now squashed down to one commit. 😸

[arthurschreiber]

PEEEEEEEEEEEEEEERFEEEEECT! ❤️