Add options argument to GTRepository cloneFromURL#252
Conversation
There was a problem hiding this comment.
Also, if you could document the magic options keys, that would be wonderful !
There was a problem hiding this comment.
@tiennou - could you please elaborate on what kind of doc update is needed?
There was a problem hiding this comment.
My bad, since you mentioned moving one of the blocks in the options dict, seeing it here made me think the doc wasn't updated. ATM it just misses a list of the options keys and what they do.
ghost
assigned
|
@jspahrsummers @tiennou - I think this PR is ready to merge now. I don't think we need to wait for #254 - we can open a new PR when #254 is ready or integrate the |
|
I'm fine with that, thanks for your work @isaac ;-). |
There was a problem hiding this comment.
These keys should be file constants, and the documentation for them should appear on those constants.
|
🍫 |
|
⚡ |
|
👍 I'll let @tiennou handle the final review and merge. |
|
I'm honored ;-). Looks good to me, so I'll just merge. I'll add the Related: It seems libgit2 is adding init options to its clone method, but this can wait until someone has an use for it. |
Add options argument to GTRepository cloneFromURL
Add options argument to GTRepository cloneFromURL
3 participants
No description provided.