Skip to content

Use FilePath in TreeChanges#171

Closed
nulltoken wants to merge 1 commit into
libgit2:vNextfrom
nulltoken:fix/treechanges-paths
Closed

Use FilePath in TreeChanges#171
nulltoken wants to merge 1 commit into
libgit2:vNextfrom
nulltoken:fix/treechanges-paths

Conversation

@nulltoken

Copy link
Copy Markdown
Member

Under the hood, TreeChanges should leverage FilePath for all paths.

@nulltoken

Copy link
Copy Markdown
Member

Would this do it?

@nulltoken

Copy link
Copy Markdown
Member

Could use Path.Combine() here?

Done. I also fixed some other path concatenations and pushed them in vNext.

@nulltoken

Copy link
Copy Markdown
Member

I'm uncomfortable with TreeChanges needing to consistently use Native for looking up paths - lot of room for error. I've started a local spike to switch the inner dictionary key to FilePath, which I hope will handle that more automagically... will finish tomorrow.

Ok :)

dahlbyk pushed a commit to dahlbyk/libgit2sharp that referenced this pull request Jun 12, 2012
@dahlbyk

dahlbyk commented Jun 14, 2012

Copy link
Copy Markdown
Member Author

I don't remember if GH notifies when a new commit is pushed, but my rebound is here:
https://github.com/dahlbyk/libgit2sharp/commits/fix/treechanges-paths

@nulltoken nulltoken closed this in 824a1c1 Jun 14, 2012
@nulltoken

Copy link
Copy Markdown
Member

@dahlbyk Thanks for the review! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants