Makefile: build and use lightweight bootstrap version of bpftool#92
Merged
anakryiko merged 2 commits intolibbpf:masterfrom Jul 8, 2022
Merged
Makefile: build and use lightweight bootstrap version of bpftool#92anakryiko merged 2 commits intolibbpf:masterfrom
anakryiko merged 2 commits intolibbpf:masterfrom
Conversation
Update to latest libbpf master that removed deprecated APIs. Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
We don't need most of bpftool functionality, just the skeleton generation and, potentially, static linking, so there is no point in building full-featured final bpftool version. So build and use bootstrap bpftool. This should also ease user's pain like [0]. [0] libbpf#89 Cc: Quentin Monnet <quentin@isovalent.com> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
This was referenced Jul 8, 2022
chenhengqi
added a commit
to chenhengqi/bcc
that referenced
this pull request
Aug 1, 2022
We need bpftool for skeleton generation only, let's build and use bootstrap
bpftool like libbpf-bootstrap does ([0]). This avoids the following errors
on old kernels:
skeleton/pid_iter.bpf.c:35:10: error: incomplete definition of type 'struct bpf_link'
return BPF_CORE_READ((struct bpf_link *)ent, id);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[0]: libbpf/libbpf-bootstrap#92
Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need most of bpftool functionality, just the skeleton
generation and, potentially, static linking, so there is no point in
building full-featured final bpftool version. So build and use bootstrap
bpftool. This should also ease user's pain like [0].
[0] #89
Cc: Quentin Monnet quentin@isovalent.com
Signed-off-by: Andrii Nakryiko andrii@kernel.org