Repository navigation
ci: scan source and PR commits with gitleaks - #4209
Merged
Merged
Conversation
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4209 +/- ##
==========================================
+ Coverage 73.00% 73.03% +0.03%
==========================================
Files 490 490
Lines 59030 59030
==========================================
+ Hits 43091 43110 +19
+ Misses 12820 12808 -12
+ Partials 3119 3112 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Yisaer
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Source scanning catches credentials present in the proposed code. Scanning the PR commit range also catches credentials added and subsequently removed before review. Scanning only this range avoids repeatedly blocking changes on older findings in the base branch history.
Changes In This PR
.github/workflows/gitleaks.yamlwith a pinned checkout action, full commit history, read-only permissions, and disabled persisted checkout credentials.base.sha..head.shaon pull requests, with fully redacted output and no inline or fingerprint suppressions.Notes
#4208 has merged, and this branch has been rebased onto the updated master. Both current-source and PR-commit scans pass locally without temporary exclusions.
Validation: actionlint passed; the actual download, checksum verification, extraction, and version check passed. The cleaned source from #4208 plus this workflow scans with zero findings. An isolated repository containing a freshly generated disposable private key added and removed in successive commits passed current-source scanning but was correctly rejected by PR-range scanning.
git diff --checkpassed.Making this job a required merge check is a separate repository ruleset setting; this PR does not modify repository settings.