Skip to content

Refactor Readable.readable_parent to consider all ancestors#81

Merged
ledermann merged 3 commits into
ledermann:masterfrom
meacuna:feature/support_multi_level_inheritance
Mar 23, 2017
Merged

Refactor Readable.readable_parent to consider all ancestors#81
ledermann merged 3 commits into
ledermann:masterfrom
meacuna:feature/support_multi_level_inheritance

Conversation

@meacuna

@meacuna meacuna commented Mar 21, 2017

Copy link
Copy Markdown
Contributor

Fixes #82

@meacuna meacuna mentioned this pull request Mar 21, 2017
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 1953ed5 on meacuna:feature/support_multi_level_inheritance into 77a17f6 on ledermann:master.

@ledermann

Copy link
Copy Markdown
Owner

Great improvement! Could you a test to verify that the change works?

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling e1ab77c on meacuna:feature/support_multi_level_inheritance into 77a17f6 on ledermann:master.

@meacuna

meacuna commented Mar 22, 2017

Copy link
Copy Markdown
Contributor Author

@ledermann I pushed some modifications to the test suite you had to include the changes

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-35.0%) to 65.049% when pulling ca2cdb9 on meacuna:feature/support_multi_level_inheritance into 77a17f6 on ledermann:master.

@ledermann ledermann merged commit 26f0432 into ledermann:master Mar 23, 2017
@ledermann

Copy link
Copy Markdown
Owner

@meacuna Merged, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants