Repository navigation
Fix master CI: update test_bool_args_in_help for the #370 help change - #379
Open
glaziermag wants to merge 1 commit into
Open
glaziermag wants to merge 1 commit into
glaziermag wants to merge 1 commit into
Conversation
lebrice#370 stopped appending "(default: None)" to the help of required arguments that have no default, and updated test_issue_48.py to match. test_bools.py::test_bool_args_in_help still expected it after the required -a flag, so the Python package workflow has failed on master since lebrice#370 was merged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python package workflow has failed on master since #370 was merged (run 41934650510). #370 stopped appending
(default: None)to the help of required arguments that have no default, and updatedtest_issue_48.pyto match, buttest/test_bools.py::test_bool_args_in_helpstill expects it after the required-aflag. This PR removes it from that test's expected help text.To reproduce on master:
The help text now comes from the branch #370 added to
SimpleHelpFormatter._get_help_string(help_formatter.py#L81-L87), which bypassesArgumentDefaultsHelpFormatterfor a required argument whose default isNone.On master the 3.12 job fails with
1 failed, 1258 passed, and the jobs for the other Python versions are cancelled. #377 mentions the same failure.Fork check, with only the push trigger of
build.ymlchanged so the workflow runs on these branches. Each run was attempted twice:🤖 Generated with Claude Code