Repository navigation
Literal types not validated when loading from YAML #321
Description
Bug Description
When loading a config from a YAML file, Literal type annotation is not validated.
To Reproduce
from simple_parsing import ArgumentParser
from dataclasses import dataclass
from typing import Literal
@dataclass
class Foo:
bar: Literal["one", 2] = "one"
if __name__ == "__main__":
parser = ArgumentParser(
config_path = "example.yml"
)
parser.add_arguments(Foo, "foo")
args = parser.parse_args()
foo: Foo = args.foo
print(foo)example.yml contents:
bar: "three"
Expected behavior
simple_parsing should raise an exception like "'one' or 'two' is required for field 'bar', 'three' is an invalid value"
Actual behavior
simple_parsing does not raise an exception
Reacted by Fabrice Normandin
Activity
lebrice commentedon Aug 15, 2024
Hey there @danny-schwartz-brt , thanks for raising the issue.
This is interesting. I believe this is supposed to work, this might be a bug.
danny-schwartz-brt commentedon Aug 15, 2024
We're running into an issue where if we convert the dataclass object into a dict after reading it and then attempt to convert that dict into an object again with
simple_parsing.helpers.serialization.serializable.from_dict(), we see the exception we expected to see earlierlebrice commentedon Sep 6, 2024
Hey @danny-schwartz-brt, have you tried using something like
pydanticfor the validation ?