[Remove Vuetify from Studio] Checkboxes and chips in the library side panel#5703
[Remove Vuetify from Studio] Checkboxes and chips in the library side panel#5703LightCreator1007 wants to merge 6 commits intolearningequality:unstablefrom
Conversation
|
👋 Thanks for contributing! We will assign a reviewer within the next two weeks. In the meantime, please ensure that:
We'll be in touch! 😊 |
…olibri-studio into replace-checkbox-chip
|
Hi @LightCreator1007, thank you. Before we assign a maintainer, I will invite the community review. |
|
📢 ✨ Community Review guidance for both authors and reviewers. |
AlexVelezLl
left a comment
There was a problem hiding this comment.
Thanks @LightCreator1007! This generally looks good! Just a couple of nitpicks to fully align with the capabilities of our KDS components.
| <VChip | ||
| <StudioChip | ||
| class="ma-1" | ||
| v-on="on" |
There was a problem hiding this comment.
Perhaps we don't need this v-on="on" now, right? Because the only thing the StudioChip emits is @close, but that is only if we set the close prop to true.
| :ref="'checkbox-' + item.id" | ||
| v-model="languages" | ||
| :checked="languages.includes(item.id)" | ||
| :value="item.id" |
There was a problem hiding this comment.
Adding presentational, we should be able to use the v-model="languages" pattern here, which is now the recommended way to define a KCheckbox like this.
| </template> | ||
| <template #item="{ item }"> | ||
| <Checkbox | ||
| <KCheckbox |
There was a problem hiding this comment.
Given that this Checkbox here is just presentational (it isn't in charge of emitting the events), could you please set the presentational prop here to reflect this?
| <KCheckbox | ||
| :ref="'checkbox-' + item.value" | ||
| v-model="selections" | ||
| :checked="selections.includes(item.value)" | ||
| :value="item.value" | ||
| class="scroll-margin" | ||
| > |
There was a problem hiding this comment.
Idem, we can use presentational and v-model here too.
Summary
Replaces Checkbox with KCheckbox and VChip with StudioChip.
References
fixes #5673