Skip to content

[Remove Vuetify from Studio] Checkboxes and chips in the library side panel#5703

Open
LightCreator1007 wants to merge 6 commits intolearningequality:unstablefrom
LightCreator1007:replace-checkbox-chip
Open

[Remove Vuetify from Studio] Checkboxes and chips in the library side panel#5703
LightCreator1007 wants to merge 6 commits intolearningequality:unstablefrom
LightCreator1007:replace-checkbox-chip

Conversation

@LightCreator1007
Copy link
Contributor

Summary

Replaces Checkbox with KCheckbox and VChip with StudioChip.

References

fixes #5673

image image

@learning-equality-bot
Copy link

👋 Thanks for contributing!

We will assign a reviewer within the next two weeks. In the meantime, please ensure that:

  • You ran pre-commit locally
  • All issue requirements are satisfied
  • The contribution is aligned with our Contributing guidelines. Pay extra attention to Using generative AI. Pull requests that don't follow the guidelines will be closed.

We'll be in touch! 😊

@LightCreator1007 LightCreator1007 changed the title replaced Checkbox with KCheckbox and VChip with StudioChip [Remove Vuetify from Studio] Checkboxes and chips in the library side panel Feb 15, 2026
@MisRob
Copy link
Member

MisRob commented Feb 17, 2026

Hi @LightCreator1007, thank you. Before we assign a maintainer, I will invite the community review.

@MisRob
Copy link
Member

MisRob commented Feb 17, 2026

📢 ✨ Community Review guidance for both authors and reviewers.

@AlexVelezLl AlexVelezLl self-assigned this Feb 23, 2026
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LightCreator1007! This generally looks good! Just a couple of nitpicks to fully align with the capabilities of our KDS components.

<VChip
<StudioChip
class="ma-1"
v-on="on"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we don't need this v-on="on" now, right? Because the only thing the StudioChip emits is @close, but that is only if we set the close prop to true.

:ref="'checkbox-' + item.id"
v-model="languages"
:checked="languages.includes(item.id)"
:value="item.id"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding presentational, we should be able to use the v-model="languages" pattern here, which is now the recommended way to define a KCheckbox like this.

</template>
<template #item="{ item }">
<Checkbox
<KCheckbox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this Checkbox here is just presentational (it isn't in charge of emitting the events), could you please set the presentational prop here to reflect this?

Comment on lines +25 to 30
<KCheckbox
:ref="'checkbox-' + item.value"
v-model="selections"
:checked="selections.includes(item.value)"
:value="item.value"
class="scroll-margin"
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem, we can use presentational and v-model here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remove Vuetify from Studio] Checkboxes and chips in the library side panel

3 participants