[Remove Vuetify from Studio] Deactivate and delete confirmation dialogs in admin user actions#5426
Conversation
|
Thank you @Prashant-thakur77, we will assign a reviewer next week. |
MisRob
changed the title
|
Hi @rtibbles @AlexVelezLl will update the pr as soon as changes in the below given pr gets merged as they are related to the issue faced here.learningequality/kolibri-design-system#1138 this is the concerned pr. ;) |
Prashant-thakur77
force-pushed
the
fix/remove-vuetify-user-dialogs-5411
branch
2 times, most recently
from
68bfdd5 to
00673ad
Compare
|
Hi @AlexVelezLl , I've implemented the changes. Please review when you have time and let me know if there are any further adjustments needed. I'm happy to make any improvements you suggest. |
|
Hi @Prashant-thakur77, I think we need to wait until we install the new KDS release with your update since you need it here too, right? |
|
Yes @MisRob |
|
Okay, we will coordinate with you :) Then let the reviewers know after that's done, please - it's best to review after all is set up. We couldn't merge it anyway any time sooner. Thank you |
|
Hi @Prashant-thakur77, we've just installed to Studio's |
Prashant-thakur77
force-pushed
the
fix/remove-vuetify-user-dialogs-5411
branch
from
ebcfc67 to
5e86660
Compare
|
@AlexVelezLl @MisRob i have Rebased the pr to the latest and checked the working locally.Do tell if any changes are needed :) |
AlexVelezLl
left a comment
AlexVelezLl
left a comment
There was a problem hiding this comment.
Thanks a lot @Prashant-thakur77! Modals look good after the rebase! Just one little note about i18n strings that'd be great to fix before merging! 🤗
| @submit="deleteHandler" | ||
| @cancel="deleteDialog = false" | ||
| > | ||
| <p>{{ $tr('deleteUserMessage', { name: user.name }) }}</p> |
There was a problem hiding this comment.
In the administration pages, we don't use i18n strings because these pages will be visible only to the LE team. Could you please use unwrapped strings instead? (I know the issue mentions that all strings should be internationalized, but there is an exception with admin pages 😅)
There was a problem hiding this comment.
Thanks for the note.Addressed it :)
…test file to handle KModal
Prashant-thakur77
force-pushed
the
fix/remove-vuetify-user-dialogs-5411
branch
from
c2dccd9 to
b0836ee
Compare
AlexVelezLl
left a comment
AlexVelezLl
left a comment
There was a problem hiding this comment.
Thanks a lot for the quick response @Prashant-thakur77!! LGTM!
…gs in admin user actions (learningequality#5426) * Updated ConfirmationDialog to KModal and also Updated repective unit test file to handle KModal * made some changes * removed i18 strings * [pre-commit.ci lite] apply automatic fixes --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
3 participants
Fixes #5411
Summary
Migrated 2 user action confirmation dialogs from Vuetify to KDS KModal.
After images for Desktop users:
After images for Mobile users:
References
• Parent issue: #5060
Reviewer guidance
Login as a@a.com with password a
Go to Administration > Users
Click Actions dropdown in the last column of the table
Click Deactivate
Click Delete