Add regression test for and fix use of accent property for mo tag.#5391
Merged
marcellamaki merged 1 commit intolearningequality:hotfixesfrom Sep 16, 2025
Merged
Conversation
marcellamaki
approved these changes
Sep 16, 2025
Member
marcellamaki
left a comment
There was a problem hiding this comment.
I've cross referenced this with the mozilla docs (linked in PR description), and discussed my confusion about the non-standard browser support with Richard to ensure I was understanding the docs correctly. Seems okay to merge.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pydantic implementation of the mo element I had previously done was missing the non-standard
accentproperty. This was causing errors during publish for one of Peter's test channels.I took the LaTeX from that specific exercise to make a regression test, and confirmed that adding the accent property to the pydantic class resolved the issue.
References
Fixes this error I saw when running publish in an interactive shell in a disposable pod on hotfixes:
Reviewer guidance
Cross check with the MDN page: https://developer.mozilla.org/en-US/docs/Web/MathML/Reference/Element/mo#accent
I also asked Claude Code to do a follow up scan of all the MathML and HTML classes and compare them to the spec to see if anything else might be missing. It said nothing was, although I don't take that as proof positive! But at least, there's some validation that we have complete coverage now.
I think this would be fairly low risk to go into the search recommendations release - but it is probably simpler to reserve this for an immediate follow up patch release.