Add keyboard navigation links and scrolling for jumping in import modal#5321
Merged
bjester merged 2 commits intolearningequality:hotfixesfrom Aug 28, 2025
Merged
Add keyboard navigation links and scrolling for jumping in import modal#5321bjester merged 2 commits intolearningequality:hotfixesfrom
bjester merged 2 commits intolearningequality:hotfixesfrom
Conversation
8e828b5 to
21acc0e
Compare
21acc0e to
b7565bd
Compare
AlexVelezLl
approved these changes
Aug 28, 2025
Member
AlexVelezLl
left a comment
There was a problem hiding this comment.
Code changes looks good to me!
| this.loading = false; | ||
| }); | ||
| }, | ||
| setFirstChannelCardRef(ref) { |
Member
There was a problem hiding this comment.
Nice, didn't know we can save just the first reference of a list this way
Member
Author
There was a problem hiding this comment.
I didn't know it either! Apparently this is a more future proof approach for Vue 3
This was referenced Aug 28, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds keyboard navigation links that support jumping between sections of the import modal screens, that are only visible when navigating by keyboard. Also leverages the focus behavior to scroll top into view.
Out of scope: the 'Channels' select box causes KDS modality tracking to lose its keyboard state
References
closes #5268
fixes #5332
Reviewer guidance