Assessment item/exercise related fixes and tests#5072
Merged
bjester merged 2 commits intolearningequality:unstablefrom May 29, 2025
Merged
Assessment item/exercise related fixes and tests#5072bjester merged 2 commits intolearningequality:unstablefrom
bjester merged 2 commits intolearningequality:unstablefrom
Conversation
01f9b99 to
74428fe
Compare
Member
Author
|
This needs an update to fix linting, and also add a test case for a file existing in cloud storage, but not having an appropriately queryable file object (i.e. their orphaned file object got cleaned up by garbage collection). |
9489d90 to
0112c54
Compare
Only automatically write attached files to perseus file for raw perseus questions.
0112c54 to
f28e07d
Compare
bjester
reviewed
May 28, 2025
Member
bjester
left a comment
There was a problem hiding this comment.
I see one instance of IMG_PLACEHOLDER in contentcuration/contentcuration/tests/test_rest_framework.py
Should it be there?
f28e07d to
131f3bf
Compare
…rly attached during updates. Delete outdated, skipped assessment item tests.
131f3bf to
402cb28
Compare
Member
Author
Looks like the whole test case was being skipped (by me, 5 years ago) so I've just deleted it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References
This was mostly motivated by having some solid regression tests in place in preparation for #4878
Reviewer guidance
Do the perseus file generation tests provide appropriate coverage, and correctly test the behaviour? Note I did use Claude (as noted in code comments) to generate these tests, but I also carefully reviewed them, and made a lot of updates to the non-image-resize tests.
Does the placeholder being used now match up to the one we use in the frontend? https://github.com/learningequality/studio/blob/unstable/contentcuration/contentcuration/frontend/shared/views/MarkdownEditor/constants.js#L12 <-- this is the one used in the frontend, and also by ricecooker: https://github.com/learningequality/ricecooker/blob/develop/ricecooker/classes/questions.py#L226