Disable bulk editing of all new metadata#3779
Merged
rtibbles merged 2 commits intolearningequality:hotfixesfrom Nov 1, 2022
Merged
Disable bulk editing of all new metadata#3779rtibbles merged 2 commits intolearningequality:hotfixesfrom
rtibbles merged 2 commits intolearningequality:hotfixesfrom
Conversation
Prevents overriding of individual metadata.
bjester
approved these changes
Nov 1, 2022
Member
bjester
left a comment
bjester
left a comment
There was a problem hiding this comment.
Functionally works fine, but left some comments that I think should remove some extra whitespace shown in the screenshot
| /> | ||
| </VFlex> | ||
| <VFlex xs12 md6 :class="{ 'pl-2': $vuetify.breakpoint.mdAndUp }"> | ||
| <VFlex xs12 :[mdValue]="true" :class="{ 'pl-2': $vuetify.breakpoint.mdAndUp }"> |
Member
There was a problem hiding this comment.
Perhaps conditionally apply the pl-2 class on && oneSelected
| @@ -54,22 +54,25 @@ | |||
| @focus="trackClick('Description')" | |||
| /> | |||
Member
There was a problem hiding this comment.
With the computed mdValue on the VFlex below, perhaps move the v-if="oneSelected" on the description field to it's parent VFlex
Member
Author
|
Ah yeah - I was in a little bit of a rush, let's sort out that whitespace. |
Member
Author
|
Updated: Awaiting sign off from @jtamiace. |
Member
Author
|
All comments addressed, @jtamiace concurs! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Manual verification steps performed
Screenshots (if applicable)
Does this introduce any tech-debt items?
We will need to address this at least when we implement the new bulk editing workflows.
Updating the data processing to match how we handle the 'merge' behaviour for bulk editing in tags will be the first step
We will also need a way to indicate multiselect with indeterminate states in KSelect to implement this.
Fixes #3769