Skip to content

Learning Activity and Completion Criteria logic on when bulk editable#3763

Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom
bjester:bulk-allowed
Oct 24, 2022
Merged

Learning Activity and Completion Criteria logic on when bulk editable#3763
rtibbles merged 1 commit intolearningequality:hotfixesfrom
bjester:bulk-allowed

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Oct 21, 2022

Summary

Description of the change(s) you made

  • Updates the logic in the edit modal for when to allow display and editing of Learning Activity and Completion Criteria during bulk edits, according to the following rules:
    • When all selected nodes are the same kind and aren't topics, the completion criteria shows
    • When any of the selected nodes are topics, learning activity is disabled
    • When all selected are documents, completion criteria isn't required

Manual verification steps performed

  1. Open a channel with a variety of resources and folders
  2. Select multiple resources and folders, and edit them
  3. Verify the above rules according to what's selected in the edit modal

References

Fixes #3759

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowed disallowed as expected. Still saw an issue with saving bulk edits of exercise completion criteria, but unrelated to fixes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants