Skip to content

Tweaks to welcome email and signatures across all html emails#3714

Merged
bjester merged 1 commit intolearningequality:hotfixesfrom
bjester:email-tweaks
Oct 4, 2022
Merged

Tweaks to welcome email and signatures across all html emails#3714
bjester merged 1 commit intolearningequality:hotfixesfrom
bjester:email-tweaks

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Oct 4, 2022

Summary

Description of the change(s) you made

Manual verification steps performed

  1. Overrode activation email condition in views/users.py
  2. Created an account and activated it
  3. Copied the HTML into a file, unescaped newlines and quotes

Reviewer guidance

How can a reviewer test these changes?

We should re-test this on hotfixes after merging, since email clients can be finicky

References

Fixes #3713

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester requested a review from LianaHarris360 October 4, 2022 17:29
Copy link
Copy Markdown
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated code makes sense to me. More testing on hotfixes will validate the changes!

@bjester bjester merged commit b3c9024 into learningequality:hotfixes Oct 4, 2022
@bjester bjester mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants