Skip to content

Strings n things#3697

Merged
bjester merged 3 commits intolearningequality:hotfixesfrom
rtibbles:strings_n_things
Sep 29, 2022
Merged

Strings n things#3697
bjester merged 3 commits intolearningequality:hotfixesfrom
rtibbles:strings_n_things

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

  • Updates strings according to feedback from string review
  • Updates most 'field required' specific messages to a generic 'This field is required' - with the exception of the license description which has additional explanatory text as to why a description is needed.
  • Removes string typos that were copy pasted from Kolibri strings
  • Sorts the 'Requirements' dropdown
  • Separates out peers and teachers to align with original spec
  • Adds a contextual hint to add further description in case of catch all 'other supplies' selection
  • Moves the For Beginners annotation out of the dropdown and into a separate checkbox under the Audience section

Manual verification steps performed

  1. Verified updated sorting and display of requirements dropdown
  2. Confirmed functionality and backend persistence of new for beginners checkbox

Screenshots (if applicable)

image

image

image

Does this introduce any tech-debt items?

I used KCheckbox to avoid relying on the soon to be deprecated Checkbox and VCheckbox but this might need to be tidied up as I had to tweak styling to match the existing checkboxes @thanksameeelian FYI!

References

Fixes #3686
Fixes #3695

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Add for beginners checkbox.
Remove persistence of kolibri string label typos.
Copy link
Copy Markdown
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not able to test this to see the strings live, but all the suggested changes seem to be in place 👍🏽
Looking forward to seeing them on Crowdin! 💯 :shipit:

Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants