Skip to content

Misc fixes to channel editing experience#3489

Merged
rtibbles merged 8 commits intolearningequality:unstablefrom
bjester:misc-fixes
Aug 10, 2022
Merged

Misc fixes to channel editing experience#3489
rtibbles merged 8 commits intolearningequality:unstablefrom
bjester:misc-fixes

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Aug 5, 2022

Summary

Description of the change(s) you made

  • Fixes task progress, for things like publishing, not being reported to the frontend
  • Fixes issue where newly uploaded files fail to be added to the clipboard
  • Fixes issue where newly uploaded files do not have proper ordering in the current topic/folder view
  • Fixes issue where completion criteria options do not render when creating a new exercise
  • Adds decorator that de-duplicates attempts to queue the user storage calculation task

Manual verification steps performed

  1. Published a large channel and ensure that % progress is updated
  2. Uploaded a file to a channel and successfully added it to the clipboard
  3. Re-ordered newly uploaded files successfully

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester requested a review from rtibbles August 5, 2022 18:23
Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still didn't have quite a big enough channel to see the progress updating - but the status changes look correct to me, and everything else checked out manually.

@rtibbles rtibbles merged commit 16e3864 into learningequality:unstable Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants