Skip to content

Fix default upload duration being shown in raw seconds #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtibbles merged 3 commits into from
Aug 2, 2022
Merged

Fix default upload duration being shown in raw seconds #3470

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
346317a
Fix default upload duration being shown in raw seconds
vkWeb Jul 30, 2022
04a9062
Change default value of duration to 0
vkWeb Jul 30, 2022
0d57fe1
Revert back to null as default to let tests pass
vkWeb Jul 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion contentcuration/contentcuration/frontend/channelEdit/components/edit/ActivityDuration.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
v-if="audioVideoUpload && selectedDuration === 'exactTime'"
class="defaultUpload md2 sm3"
>
{{ defaultUploadTime }}
{{ convertToHHMMSS(defaultUploadTime) }}
</VFlex>
<VFlex
v-else-if="selectedDuration === 'shortActivity' || selectedDuration === 'longActivity'"
Expand Down Expand Up @@ -167,6 +167,20 @@
handleInput(value) {
this.$emit('input', this.convertToSeconds(value));
},
convertToHHMMSS(totalSeconds) {
if (totalSeconds !== null && Number.isInteger(totalSeconds)) {
const hours = Math.floor(totalSeconds / 3600)
Copy link
Copy Markdown
Member

@rtibbles rtibbles Aug 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method will give the same result and seems a little simpler: https://stackoverflow.com/a/25279399

Copy link
Copy Markdown
Member Author

@vkWeb vkWeb Aug 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That implementation breaks when input seconds are greater than or equal to 86400 seconds.

On 86400 seconds, it outputs 00:00:00. The expected output should be 24:00:00. Date objects are relative to specific parameters like timezone, etc. And our use case is absolute in nature. So, IMO the current implementation feels more robust to me.

Copy link
Copy Markdown
Member

@rtibbles rtibbles Aug 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An excellent point!

.toString()
.padStart(2, 0);
const minutes = Math.floor((totalSeconds % 3600) / 60)
.toString()
.padStart(2, 0);
const seconds = ((totalSeconds % 3600) % 60).toString().padStart(2, 0);
return `${hours}:${minutes}:${seconds}`;
} else {
return totalSeconds;
}
},
},
$trs: {
minutesRequired: 'Minutes',
Expand Down