Skip to content

Add threshold field validation and properly handle updates to mastery models in all scenarios#3436

Merged
rtibbles merged 3 commits intolearningequality:unstablefrom
rtibbles:threshold_field
Jul 20, 2022
Merged

Add threshold field validation and properly handle updates to mastery models in all scenarios#3436
rtibbles merged 3 commits intolearningequality:unstablefrom
rtibbles:threshold_field

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

  • Adds some simple validation for the threshold field to ensure it is either a string, integer coerceable or dict.
  • Ensures that updates to the threshold key of completion_criteria can be made granularly when threshold is an object
  • For example, just updating the m value of an m of n mastery model
  • Ensures that partial updates to extra fields that contain the old way of encoding mastery model (at the top level) successfully write the entire representation into the completion criteria format.
  • Adds regression tests for both scenarios

@rtibbles rtibbles merged commit 0c46585 into learningequality:unstable Jul 20, 2022
@rtibbles rtibbles deleted the threshold_field branch July 20, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants