Skip to content

#3285:Sorted issue by referencing google design#3355

Merged
sairina merged 1 commit intolearningequality:unstablefrom
d0sadata:storage_issues
Apr 1, 2022
Merged

#3285:Sorted issue by referencing google design#3355
sairina merged 1 commit intolearningequality:unstablefrom
d0sadata:storage_issues

Conversation

@d0sadata
Copy link
Copy Markdown
Contributor

@d0sadata d0sadata commented Mar 29, 2022

Resolves #3285

Changed way storage is calculated in User's own settings.

Tested with the current storage fill i have 2 B out of 524 MB counts em out correctly
Cant test changes cause my upload process seems to be bugged.

Screenshots (if applicable)
image

Does this introduce any tech-debt items?
There seems to be another type of calculation done in FIleStorage. Don't know if we need to consolidate.

Are there any risky areas that deserve extra testing?
Test storage increase and decrese.

References
My reference for the change.
https://developers.google.com/web/updates/2017/08/estimating-available-storage-space)

Comments
There are a lot of errors when I fixed this.

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@d0sadata d0sadata changed the title #3285: sorted issue by referencing google design Sorted issue by referencing google design Mar 29, 2022
@d0sadata d0sadata changed the title Sorted issue by referencing google design #3285:Sorted issue by referencing google design Mar 29, 2022
Copy link
Copy Markdown
Contributor

@sairina sairina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Math.round does the trick. Thank you for fixing this.
Screen Shot 2022-03-31 at 11 28 13 PM
Screen Shot 2022-03-31 at 11 35 40 PM

@sairina sairina merged commit ce47420 into learningequality:unstable Apr 1, 2022
@d0sadata d0sadata deleted the storage_issues branch April 1, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User storage not properly reported in the frontend

2 participants