Skip to content

Catch errors, prevent warning, and add more logging to garbage collection#3261

Merged
bjester merged 3 commits intolearningequality:hotfixesfrom
rtibbles:taking_out_the_trash
Aug 16, 2021
Merged

Catch errors, prevent warning, and add more logging to garbage collection#3261
bjester merged 3 commits intolearningequality:hotfixesfrom
rtibbles:taking_out_the_trash

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

  • Added more logging to the garbage collection utilities and management command
  • Catches an error that seems to happen during deletion of orphanage nodes
  • Uses timezone aware datetime to prevent warning

Manual verification steps performed

  1. Ran the garbage_collect management command

Screenshots (if applicable)

Cleaning up contentnodes from the orphan tree
INFO:command:Cleaning up contentnodes from the orphan tree
INFO:root:Deleted 0 node(s) from the orphanage tree
Cleaning up deleted chef nodes
INFO:command:Cleaning up deleted chef nodes
Cleaning up feature flags
INFO:command:Cleaning up feature flags
Cleaning up tasks
INFO:command:Cleaning up tasks
INFO:root:Deleted 0 successful task(s) from the task queue

References

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bjester bjester merged commit 49c30b8 into learningequality:hotfixes Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants