Remove API request consolidation across tabs.#3256
Merged
marcellamaki merged 8 commits intolearningequality:unstablefrom Aug 11, 2021
Merged
Remove API request consolidation across tabs.#3256marcellamaki merged 8 commits intolearningequality:unstablefrom
marcellamaki merged 8 commits intolearningequality:unstablefrom
Conversation
918b623 to
98b5105
Compare
|
Kudos, SonarCloud Quality Gate passed! |
marcellamaki
approved these changes
Aug 11, 2021
Member
marcellamaki
left a comment
There was a problem hiding this comment.
Manual QA indicates this has resolved the loading issue! Code read-through also looks good and tests passing locally ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Summary
Description of the change(s) you made
Manual verification steps performed
Reviewer guidance
How can a reviewer test these changes?
Are there any extant references to
requestCollectionorrequestModelthat I missed?Do pages load as expected.
Are there any risky areas that deserve extra testing?
I think if anything, this reduces complexity and risk for the most part.
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)