Merged
Conversation
Catch integrity error to handle both sides of missing prerequisite relationships.
sairina
approved these changes
Jul 9, 2021
Contributor
sairina
left a comment
There was a problem hiding this comment.
lgtm! Everything seems to be fixed. Thank you!
bjester
reviewed
Jul 9, 2021
|
|
||
|
|
||
| def map_content_nodes( | ||
| def map_content_nodes( # noqa: C901 |
Member
There was a problem hiding this comment.
Ah that's how to do it with a multi-line arguments list
Member
Author
There was a problem hiding this comment.
It took me a couple of tries...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Setup does not run since the Django 3.2 upgrade
Tighter SQLite foreign key constraints made this issue surface
Fixes this by handling integrity errors in setting prerequisite relationships and by not setting root nodes as incomplete in the
mark_incompletecommand.Should at least provide more diagnostic errors for #3234 if it does not fix it
Manual verification steps performed
./contentcuration/manage.py setupit did not break!Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)