Remove Django Admin in production mode#3027
Merged
rtibbles merged 3 commits intolearningequality:hotfixesfrom Mar 18, 2021
lkbhitesh07:AdminPref
Merged
Remove Django Admin in production mode#3027rtibbles merged 3 commits intolearningequality:hotfixesfrom lkbhitesh07:AdminPref
rtibbles merged 3 commits intolearningequality:hotfixesfrom
lkbhitesh07:AdminPref
Conversation
rtibbles
requested changes
Mar 18, 2021
Member
rtibbles
left a comment
There was a problem hiding this comment.
Nearly there, can simplify the fix.
Codecov Report
@@ Coverage Diff @@
## hotfixes #3027 +/- ##
============================================
- Coverage 85.73% 85.71% -0.02%
============================================
Files 298 298
Lines 15876 15879 +3
============================================
Hits 13611 13611
- Misses 2265 2268 +3
Continue to review full report at Codecov.
|
rtibbles
approved these changes
Mar 18, 2021
This was referenced Mar 26, 2021
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Description of the change(s) you made
To not run django in production mode I have made some changes in settings file as I added condition to it and done some changes in URL file too.
Does this introduce any tech-debt items?
Issue - #3016
Reviewer guidance
How can a reviewer test these changes?
We can simply check if we can access the admin panel in production mode.
References
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)