Skip to content

Remove Django Admin in production mode#3027

Merged
rtibbles merged 3 commits intolearningequality:hotfixesfrom
lkbhitesh07:AdminPref
Mar 18, 2021
Merged

Remove Django Admin in production mode#3027
rtibbles merged 3 commits intolearningequality:hotfixesfrom
lkbhitesh07:AdminPref

Conversation

@lkbhitesh07
Copy link
Copy Markdown
Contributor

Summary

Description of the change(s) you made

To not run django in production mode I have made some changes in settings file as I added condition to it and done some changes in URL file too.

Does this introduce any tech-debt items?

Issue - #3016


Reviewer guidance

How can a reviewer test these changes?

We can simply check if we can access the admin panel in production mode.

References


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there, can simplify the fix.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2021

Codecov Report

Merging #3027 (c59593b) into hotfixes (deb4663) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           hotfixes    #3027      +/-   ##
============================================
- Coverage     85.73%   85.71%   -0.02%     
============================================
  Files           298      298              
  Lines         15876    15879       +3     
============================================
  Hits          13611    13611              
- Misses         2265     2268       +3     
Impacted Files Coverage Δ
contentcuration/contentcuration/settings.py 90.62% <ø> (ø)
contentcuration/contentcuration/urls.py 95.16% <ø> (ø)
...uration/contentcuration/tests/test_urlendpoints.py 93.75% <0.00%> (-2.09%) ⬇️
contentcuration/contentcuration/tasks.py 62.72% <0.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb4663...c59593b. Read the comment docs.

@radinamatic
Copy link
Copy Markdown
Member

Tested and not found! 😛

Selection_001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants