Rename RouterNames -> RouteNames#2939
Merged
rtibbles merged 1 commit intolearningequality:developfrom Feb 12, 2021
Merged
Conversation
Member
|
@jonboiser as this is not a bug fix, could you retarget this to develop? |
jonboiser
force-pushed
the
rename-routernames
branch
2 times, most recently
from
ef829bd to
b1760a8
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2939 +/- ##
========================================
Coverage 84.85% 84.85%
========================================
Files 292 292
Lines 15338 15338
========================================
Hits 13015 13015
Misses 2323 2323 Continue to review full report at Codecov.
|
jonboiser
force-pushed
the
rename-routernames
branch
from
b1760a8 to
edabaf1
Compare
MisRob
approved these changes
Feb 12, 2021
Member
MisRob
left a comment
MisRob
left a comment
There was a problem hiding this comment.
Thank you, @jonboiser. I've checked the diff and clicked through the important paths in the app. Everything looks good to me. Before merging, could you please run yarn lint-all:fix to fix the failing linting check?
Do you have githooks installed for Studio? This should run automatically before a commit.
jonboiser
force-pushed
the
rename-routernames
branch
from
edabaf1 to
526c1a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames all
RouterNamestokens toRouteNames.Fixes #2028