Hotfixes - Bulk editing resources of the same type - The completion drop-down is defaulting to the first value after finishing

[pcenov]

Observed behavior

As noted by @radinamatic when a user is bulk editing resources of the same type the Completion drop-down is not functioning correctly as it keeps defaulting to the first value after having selected anything else. The issue is valid for all resource types. Note that it appears that after selecting a value different from the default one and clicking the Finish button the change is not applied but if you open a resource separately the set completion criteria is actually displayed correctly.

Expected behavior

It should be possible to set a Completion value different than the default without any interruptions.

Steps to reproduce the issue

1. Go to https://hotfixes.studio.learningequality.org/en/accounts/#/ and sign in
2. Open a channel and select several resources of the same type
3. Click the Edit option
4. While in the Edit details modal, attempt to change the completion criteria.

Additional information

2022-11-04_12-34-22.mp4

Usage Details

• OS: Windows 10, Ubuntu
• Browser: Chrome, Firefox
• URL: https://hotfixes.studio.learningequality.org/

[pcenov]

@radinamatic

[radinamatic]

While when bulk editing the video/audio, document and HTML files, it seems easier to imagine all being edited would have the same duration/completion features, goals completion for exercises could have different values. Not sure if this is another reason to fully disable bulk editing completion/duration, even when all the selected resources are of the same type 🤔

change is not applied but if you open a resource separately the set completion criteria is actually displayed correctly.

Yes, confirmed by my testing yesterday too, even the Allow learners to mark as complete (what I was originally testing when I encountered this issue) seems to need to checking of the box to be properly saved.

cc @marcellamaki @bjester @rtibbles

[rtibbles]

This has been fixed to the extant of preventing breakage by #3798 - the fix is not ideal, inasmuch as it limits edits to only the completion criteria first (and also prevents edits to the 'learner managed' option, until the completion criteria is the same). This is not ideal from a user experience perspective, but is better than the alternative.