Add support for percentage threshold for pages completion criteria#103
Merged
bjester merged 4 commits intolearningequality:mainfrom Mar 29, 2022
Merged
Add support for percentage threshold for pages completion criteria#103bjester merged 4 commits intolearningequality:mainfrom
pages completion criteria#103bjester merged 4 commits intolearningequality:mainfrom
Conversation
21eb6b8 to
a1e61d0
Compare
Merged
24 tasks
sairina
approved these changes
Mar 28, 2022
Contributor
sairina
left a comment
There was a problem hiding this comment.
Now that mastery and completion criteria are separated, will there need to be any updates I need to make to imports in Studio's frontend to address that?
rtibbles
requested changes
Mar 29, 2022
Member
rtibbles
left a comment
There was a problem hiding this comment.
Could you also increment the version in setup.py and rerun the build process, and commit the resulting changes in package.json too? Then we can just tag and release straight away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pagescompletion criteria