Skip to content

Define schema for completion criteria#102

Merged
rtibbles merged 1 commit intolearningequality:mainfrom
bjester:completion-criteria-schema
Jan 27, 2022
Merged

Define schema for completion criteria#102
rtibbles merged 1 commit intolearningequality:mainfrom
bjester:completion-criteria-schema

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Jan 19, 2022 •
edited
Loading

  • Adds schema for completion criteria
  • Integrates schema with generator script
  • Tests the schema to ensure it will accept appropriate data (skipped with Python 3.4 due to dependency issues)

@bjester bjester requested a review from rtibbles January 19, 2022 23:44
@bjester
- Define schema for completion criteria
3908c24 
- Lower jsonschema test requirement to work for more pythons
- Skip schema tests for python 3.4 since supporting jsonschema package is too old
@bjester bjester force-pushed the completion-criteria-schema branch from 9abacc2 to 3908c24 Compare January 20, 2022 17:26
@bjester bjester mentioned this pull request Jan 27, 2022
Merged
24 tasks
rtibbles
rtibbles approved these changes Jan 27, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proof is in the output!

@rtibbles rtibbles merged commit 2d5fc88 into learningequality:main Jan 27, 2022
@bjester bjester mentioned this pull request Mar 11, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rtibbles rtibbles rtibbles approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bjester @rtibbles