Remove remaining duplicate PageNames definitions in coach plugin#14467
Merged
AlexVelezLl merged 1 commit intolearningequality:release-v0.19.xfrom Mar 30, 2026
Merged
Remove remaining duplicate PageNames definitions in coach plugin#14467AlexVelezLl merged 1 commit intolearningequality:release-v0.19.xfrom
AlexVelezLl merged 1 commit intolearningequality:release-v0.19.xfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
APP: Coach
Contributor
Build Artifacts
Smoke test screenshot |
AlexVelezLl
approved these changes
Mar 30, 2026
Member
AlexVelezLl
left a comment
AlexVelezLl
left a comment
There was a problem hiding this comment.
Code changes make sense. I have smoke tested the affected pages on the browser, and everything is still working correctly.
AlexVelezLl
merged commit 4e11206
into
learningequality:release-v0.19.x
59 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #14463 — remove the remaining duplicate
PageNamesdefinitions in 5 more coach plugin files, as identified by @AlexVelezLl in this comment.PageNamesis already provided by thecommonCoachmixin.References
Follows up on #14463 (comment: #14463 (comment))
Reviewer guidance
Verify that pages using
PageNamesstill route correctly: GroupMembersPage, ReportsResourceHeader, GroupEnrollPage, LearnerLessonPage, LessonLearnerPage.Manually verified against devserver that the Groups page, Lessons list, lesson detail (Resources and Learners tabs), learner detail page, and LearnerLessonPage all load and render correctly with no console errors. Exercise links using
PageNamesroute references render as expected.AI usage
Used Claude Code to find and remove the duplicate
PageNamesdefinitions across the 5 files identified in Alex's comment. Verified linting passes and manually verified affected pages in the browser.