Inline help fixes#5001
Merged
66eli77 merged 3 commits intoMar 17, 2016
Merged
Conversation
If the user clicks the button and no help is available, show a warning message and disable the button. Also fixes the pattern matching for the management page.
The previous element no longer exists.
Selectors were broken, and bootstrap src must be made available for reloading.
Contributor
|
I cherry pick your commit and make sure all your changes are present, but the issue still exists, and can not get what you show on your screen shoot. Did I miss anything? I tried Ok, I need to remove two files |
66eli77
added a commit
that referenced
this pull request
Mar 17, 2016
the fix is nice and concise. Merged, but open an new issue for improvement on bootstrap disable and enable. Ideally, we want to avoid reloading bootstrap everytime the "show me how!" button is clicked.
Contributor
|
the fix is nice and concise. Merged, but open an new issue for improvement on bootstrap disable and enable #5011 . Ideally, we want to avoid reloading bootstrap everytime the "show me how!" button is clicked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4986. Clicking on the inline help on that page now disables the button and creates a warning bubble. See screenshots.
Also fixes up the existing inline help which was broken due to UI changes.
TODO
Not clear how to test this... Maybe in the future, when the UI changes the changer must be responsible for double checking the inline help feature on that page?
Issues addressed
Fixes #4986.
Screenshots (if appropriate)