Escapes %s to stop sprintf throwing an error.#4963
Merged
Conversation
Collaborator
|
Looks good. Just in time, I was about to release the new po files. @radinamatic would you be able to test this by today? |
Member
Author
|
I think it's easier for @radinamatic to test post merge into a build, as I am not sure that pulling feature branches fits well into her testing workflow. |
Member
Author
|
If it looks good to you, I would say merge it. |
Collaborator
|
Sounds good. |
aronasorman
added a commit
that referenced
this pull request
Mar 7, 2016
Escapes %s to stop sprintf throwing an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some text that contained % symbols did not use %% to escape them. This made sprintf get mad.
Issues addressed
Fixes #4951