Skip to content

Preseed dist with content item db#4804

Closed
benjaoming wants to merge 5 commits into
learningequality:0.16.xfrom
benjaoming:content_items_preseed
Closed

Preseed dist with content item db#4804
benjaoming wants to merge 5 commits into
learningequality:0.16.xfrom
benjaoming:content_items_preseed

Conversation

@benjaoming

Copy link
Copy Markdown
Contributor

Fix for #4802

@benjaoming benjaoming self-assigned this Feb 2, 2016
@benjaoming benjaoming added this to the 0.16.0 milestone Feb 2, 2016
@benjaoming benjaoming mentioned this pull request Feb 3, 2016
7 tasks
@benjaoming benjaoming changed the title [WIP] Preseed dist with content item db Preseed dist with content item db Feb 3, 2016
@benjaoming

Copy link
Copy Markdown
Contributor Author

@rtibbles would you be able to comment on the most recent test failure?

@rtibbles

rtibbles commented Feb 8, 2016

Copy link
Copy Markdown
Member

Seems to be flakiness in the Item Rating Behave tests - @MCGallaspy any ideas?

@rtibbles

rtibbles commented Feb 8, 2016

Copy link
Copy Markdown
Member

Otherwise, nothing hugely problematic here, except that content data should be coming from an external source, not our old json files.

If we want to just have a content database to seed the dist with, we should probably just have a dummy fixture - as none of the content will be available, except the Khan Exercises (not Perseus).

@MCGallaspy

Copy link
Copy Markdown
Contributor

Seems to be flakiness in the Item Rating Behave tests - @MCGallaspy any ideas?

I guess it times out waiting for some condition to be fulfilled. Same step passes in another test. I say merge anyway, and we'll address the test separately.

@benjaoming

Copy link
Copy Markdown
Contributor Author

There were issues about this approach, so we need to implement content DBs from the content packs before this can be used. Manually merging stuff from this PR into #4865.

@benjaoming benjaoming closed this Feb 18, 2016
@benjaoming benjaoming removed the has PR label Feb 18, 2016
@benjaoming
benjaoming deleted the content_items_preseed branch October 6, 2016 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants