Skip to content

Coach report fixes#4414

Merged
MCGallaspy merged 23 commits into
learningequality:0.15.xfrom
rtibbles:coach_report_fixes
Sep 14, 2015
Merged

Coach report fixes#4414
MCGallaspy merged 23 commits into
learningequality:0.15.xfrom
rtibbles:coach_report_fixes

Conversation

@rtibbles

Copy link
Copy Markdown
Member

Fixes #4337, fixes #4338, fixes #4339, fixes #4340, fixes #4341, fixes #4342, fixes #4343, fixes #4349, fixes #4351, fixes #4366.

Summary of changes:
See commit messages!

@MCGallaspy these are mostly bugs filed by you, one by @66eli77 .

@rtibbles rtibbles added this to the 0.15.0 milestone Sep 11, 2015
@MCGallaspy MCGallaspy self-assigned this Sep 12, 2015
@MCGallaspy

Copy link
Copy Markdown
Contributor

Re #4342 -- toggling the visibility of the datepicker refresh button changes the width of some elements, instead of appending the refresh button:

ss2

But otherwise the fix seems okay.

@rtibbles

Copy link
Copy Markdown
Member Author

Unfortunately appending causes some weird issues all of it's own.

Might be better just to enable/disable the button for a smooth experience.

@rtibbles

Copy link
Copy Markdown
Member Author

@MCGallaspy made the fix I suggested.

@MCGallaspy

Copy link
Copy Markdown
Contributor

Good, I'll just wait for the build to finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants