chore: bump toolchain to nightly-2024-10-07 - #217
Merged
Merged
Conversation
Collaborator
Author
|
@bollu the traces for the CSE tests changed. I've accepted the new trace somewhat blindly; could you confirm the difference is benign? |
Collaborator
|
Yep, LGTM! |
This was referenced Oct 7, 2024
Collaborator
|
FYI: draperlaboratory/ELFSage#15 where the toolchain is While that's upstreamed, we can use my fork of ELFSage. |
alexkeizer
changed the title
Collaborator
|
FYI: draperlaboratory/ELFSage#15 got merged. No need to use my fork. |
3 tasks done
@bollu: please double check the new test output makes sense!
This is needed to work around leanprover/lean4#5664 TL;DR: the normalization pass actively made it harder for the SAT solver to prove our goals, causing much larger LRAT files and even timeouts for some pathological goals
alexkeizer
force-pushed
the
bump-toolchain-2024-10-04
branch
from
October 10, 2024 21:17
522d78b to
1ba0840
Compare
`bv_omega` got stuck in an infinite loop, but by translating to bitvectors and breaking up the proof we got the proof to go through
`bv_omega` was no longer able to prove the last `BitVec.toNat_mul_of_lt` side-condition, but the proof seems to go through if we remove that rewrite anyway
We introduced a few more general bitvec theorems, in the hope that the proof is a bit more robust using these
alexkeizer
changed the title
alexkeizer
marked this pull request as ready for review
October 11, 2024 18:34
shigoel
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Bumps the toolchain to the latest nightly. Mostly in the (unlikely) hope that some of our
instantiateMVarsperformance woes might disappear.Testing:
What tests have been run? Did
make allsucceed for your changes? Wasconformance testing successful on an Aarch64 machine? Yes
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.