Improve compile time abs implementation#189
Closed
namannimmo10 wants to merge 2 commits intolcompilers:mainfrom
Closed
Improve compile time abs implementation#189namannimmo10 wants to merge 2 commits intolcompilers:mainfrom
abs implementation#189namannimmo10 wants to merge 2 commits intolcompilers:mainfrom
Conversation
certik
reviewed
Feb 28, 2022
certik
reviewed
Feb 28, 2022
Collaborator
Author
|
I think you're right, we definitely need to implement a generic |
Collaborator
Author
|
I will decorate the |
Contributor
|
Overloads don't work in LPython yet, see #187. |
czgdp1807
reviewed
Mar 9, 2022
Comment on lines
+101
to
+102
| ASR::ttype_t *int_type = ASRUtils::TYPE(ASR::make_Integer_t(al, loc, 4, nullptr, 0)); | ||
| ASR::ttype_t *real_type = ASRUtils::TYPE(ASR::make_Real_t(al, loc, 8, nullptr, 0)); |
Collaborator
There was a problem hiding this comment.
Can we take the kind from args[0]'s type instead of defaulting it to 8 or 4?
Collaborator
Author
There was a problem hiding this comment.
Yes, we should, perhaps everywhere in the codebase.
czgdp1807
reviewed
Mar 9, 2022
Collaborator
Author
|
This was included in #250. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.