Sync `libasr` with LFortran#1535

Merged

czgdp1807 merged 4 commits intolcompilers:mainfrom

czgdp1807:libasr_sync_2

Feb 21, 2023

Collaborator

czgdp1807 commented Feb 20, 2023 •

edited

Loading

Corresponding LFortran PR - lfortran/lfortran#1325

czgdp1807 commented

View reviewed changes

src/libasr/asdl_cpp.py

                       subs["MOD"] = "LPython::AST"
                       subs["mod"] = "ast"
                       subs["lcompiler"] = "lpython"
+                  elif subs["MOD"] == "AST":

Collaborator Author

czgdp1807 Feb 20, 2023

Shouldn't it be "LFORTRAN" instead of "AST"?

Contributor

certik Feb 20, 2023

We haven't been consistent in the asdl if I remember well, so I would not do any big changes in the sync PRs, but we can fix things up later.

certik reviewed

View reviewed changes

src/libasr/codegen/wasm_to_x64.cpp Outdated Show resolved Hide resolved

Contributor

certik commented Feb 20, 2023

Otherwise it looks good.

czgdp1807 force-pushed the libasr_sync_2 branch from 98a2105 to 6f85de9 Compare

February 20, 2023 04:20

Thirumalai-Shaktivel reviewed

View reviewed changes

src/libasr/codegen/asr_to_llvm.cpp Show resolved Hide resolved

Thirumalai-Shaktivel reviewed

View reviewed changes

src/libasr/codegen/asr_to_llvm.cpp Show resolved Hide resolved

Thirumalai-Shaktivel reviewed

View reviewed changes

src/libasr/codegen/asr_to_llvm.cpp Show resolved Hide resolved

Thirumalai-Shaktivel reviewed

View reviewed changes

src/libasr/runtime/lfortran_intrinsics.c Show resolved Hide resolved

Thirumalai-Shaktivel reviewed

View reviewed changes

src/libasr/pass/print_list.cpp Show resolved Hide resolved

Thirumalai-Shaktivel reviewed

View reviewed changes

src/libasr/compiler_tester/tester.py Show resolved Hide resolved

czgdp1807 force-pushed the libasr_sync_2 branch 2 times, most recently from dd6a551 to 60e3bb0 Compare

February 20, 2023 08:01

Pranavchiku approved these changes

View reviewed changes

Collaborator

Pranavchiku left a comment

Looks good to me!

ubaidsk reviewed

View reviewed changes

src/libasr/asr_utils.h Outdated Show resolved Hide resolved

Collaborator

ubaidsk commented Feb 20, 2023

For the files asr_to_wasm.cpp, asr_to_x86.cpp, wasm_assembler.h, wasm_decoder.h, wasm_to_wat.cpp, wasm_to_x64.cpp, wasm_to_x86.cpp, wasm_utils.h, x86_assembler.cpp, x86_assembler.h, please, could you keep the same version as in current lpython master? And then we have to add the changes in lfortran/lfortran#1216 and lfortran/lfortran#1304.

czgdp1807 force-pushed the libasr_sync_2 branch from 60e3bb0 to 132006f Compare

February 20, 2023 09:21

czgdp1807 added 2 commits

February 20, 2023 15:12


          Sync libasr with LFortran

e2ebfb7


          Updated reference tests

51e94cc

czgdp1807 force-pushed the libasr_sync_2 branch from 132006f to 51e94cc Compare

February 20, 2023 09:44

czgdp1807 mentioned this pull request

Sync libasr with LPython lfortran/lfortran#1325

Merged

ubaidsk approved these changes

View reviewed changes

Collaborator

ubaidsk left a comment

It looks good to me. Thank you so much for this!


          Insert changes from LFortran

9993dcc

czgdp1807 force-pushed the libasr_sync_2 branch from c2fb2e9 to 9993dcc Compare

February 20, 2023 14:32

czgdp1807 marked this pull request as ready for review

February 20, 2023 14:58


          Remove redundant result = false;

b9568c2

ubaidsk mentioned this pull request

WASI support lfortran/lcompilers_frontend#64

Merged

Thirumalai-Shaktivel reviewed

View reviewed changes

Collaborator

Thirumalai-Shaktivel left a comment

LGTM, Thank you! 😃

Thirumalai-Shaktivel approved these changes

View reviewed changes

Smit-create approved these changes

View reviewed changes

Collaborator

Smit-create left a comment

Thanks, @czgdp1807. LGTM!!

certik approved these changes

View reviewed changes

Contributor

certik left a comment

This looks good to me.

czgdp1807 merged commit ac56812 into lcompilers:main

czgdp1807 deleted the libasr_sync_2 branch

February 21, 2023 16:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet