Repository navigation
Added donePressed on onClose callback - #319
Merged
Merged
Conversation
FabianoBrancher
approved these changes
May 6, 2020
FabianoBrancher
approved these changes
May 6, 2020
FabianoBrancher
approved these changes
May 6, 2020
yuritoledo
approved these changes
Jul 1, 2020
juanbazpera
approved these changes
Jan 22, 2021
|
Is there any reason this hasnt been merged yet? Would be great to have this functionailty 馃槃 |
|
@AlissonEnz can we merge this? |
Contributor
Author
|
Hi @Zakyyy, I opened this PR a long time ago and I think this library is not maintained anymore. But I can reopen the PR and see if I can merge |
lfkwtz
approved these changes
Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it'd be great to know on the
onClosefunction if the done was pressed or not.In my case, when the user scrolls through the picker I want to update only the input, and I want to update the view when the Done is pressed. Otherwise, I want to revert the input with the previous data if it's closed without pressing the Done button on iOS.
I've already updated the docs matching the functions with open and close parenthesis ().