Merged
Conversation
Owner
|
Thanks for the PR! The change makes sense — no reason to leave the connection open when authentication fails. One thought: since initialize() can also fail on starttls() or ehlo_or_helo_if_needed(), it might be worth catching Exception instead of just SMTPAuthenticationError to clean up the connection on any initialization failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slight improvement to the SMTPClient. Currently the client does not gracefully quit the connection when authentication fails. While the socket is eventually closed on GC, this could be done earlier by explicitly quitting.
(Found while testing python-emails in RosettaTest)