Skip to content

fix(web): keep annotation actions attached to dialog - #73

Merged
lastobelus merged 1 commit into
lastcode/mainfrom
lastcode/fix-annotation-editor-dialog
Aug 23, 2026
Merged

lastobelus merged 1 commit into
lastcode/mainfrom
lastcode/fix-annotation-editor-dialog

Conversation

@lastobelus

Copy link
Copy Markdown
Owner

The annotation editor's action footer could detach from the dialog because a form wrapper interrupted the shared dialog's direct-child flex layout.

This keeps the shared header, scrolling panel, and footer as direct dialog children. The form now lives inside the panel, and the footer submit button targets it by ID, preserving Enter/submit behavior while restoring the standard modal layout.

Validation:

  • focused annotation component tests (2/2)
  • web typecheck
  • targeted lint and formatting
  • quick local CI (all workspace typechecks and tests)
  • integrated Safari QA against an isolated production build

Built by GPT-5.6-Sol with the Codex harness.

@lastobelus

ghost commented Aug 23, 2026

Copy link
Copy Markdown
Owner Author

Before (installed nightly):

annotation-dialog-before

After (fixed):

annotation-dialog-after

@lastobelus

ghost commented Aug 23, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

ghost commented Aug 23, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: d1b387192a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lastobelus
lastobelus force-pushed the lastcode/fix-annotation-editor-dialog branch from d1b3871 to d3784f5 Compare August 23, 2026 23:32
@lastobelus

ghost commented Aug 23, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

ghost commented Aug 23, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: d3784f5aeb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lastobelus
lastobelus merged commit 57ccc51 into lastcode/main Aug 23, 2026
@lastobelus
lastobelus deleted the lastcode/fix-annotation-editor-dialog branch August 23, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant