Repository navigation
test(lastcode): restore browser and repair permission fixtures - #316
Conversation
Carry-Group: incubator Carry-Observation: Handoff and markdown fixtures must advertise server-browser support to exercise preview opening after the native browser integration.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Carry-Group: incubator Carry-Observation: Repair tests distinguish the target runtime-mode guard from the full-access repair requirement and verify rejected requests never launch a repair.
lastobelus
changed the title
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Full validation fails in the saved-handoff and markdown link fixtures because their environment mocks omit the server-browser capability lookup. The repair permission test also expects the full-access requirement to run before the target runtime-mode guard.
Advertise server-browser support in both web fixtures and exercise both repair permission barriers with matching target modes. Rejected requests must never launch a repair; a full-access client still launches exactly once.
Validation: all 94 tests in the two web files and all 15 server toolkit tests pass; targeted lint, formatting, and diff checks pass. GitHub CI provides the full validation.
Implemented by gpt-6.1-sol using the Codex harness.