fix(drive): guide wiki permission recovery - #2311
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughDrive Wiki resolution now gives permission-denied code ChangesWiki permission recovery
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@1e5489f4d5d3ce966723bf3c854eb6bb3150b983🧩 Skill updatenpx skills add larksuite/cli#codex/wiki-permission-terminal-guidance -y -g |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2311 +/- ##
==========================================
- Coverage 76.47% 74.67% -1.80%
==========================================
Files 1013 1025 +12
Lines 112079 137429 +25350
==========================================
+ Hits 85707 102624 +16917
- Misses 19859 28134 +8275
- Partials 6513 6671 +158 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0210f1d to
1e5489f
Compare
Summary
When
drive +inspectunwraps a Wiki URL and the Wiki API returns code131006, return terminal resource-access guidance instead of suggesting repeated authorization or identity changes. The fix stays local to the Drive shortcut; sharedinternalerror classification and existing Wiki shortcut behavior are unchanged.Changes
131006only at thedrive +inspectWiki-resolution boundary.Test Plan
go test ./shortcuts/drive -count=1go vet ./shortcuts/drivegofmtandgit diff --checkmake unit-test— affected packages pass; the full repository run still has unrelated metadata-baseline failures incmd/schema,internal/affordance, andinternal/schema(schema count/high-risk metadata/IM image token metadata).Related Issues
Summary by CodeRabbit