Skip to content

docs(slides): +create 的参数下沉到 create.md,主 skill 只留路由 - #2096

Merged
R0bynZhu merged 5 commits into
mainfrom
fix-slides-create-doc-routing
Jul 29, 2026
Merged

docs(slides): +create 的参数下沉到 create.md,主 skill 只留路由#2096
R0bynZhu merged 5 commits into
mainfrom
fix-slides-create-doc-routing

Conversation

@R0bynZhu

@R0bynZhu R0bynZhu commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

trace 里 +create 的三类高频错误(--yes、--name、--slides 塞文件路径) 共同点是调用前没读 lark-slides-create.md。原因不是文档缺内容,而是
SKILL.md 里 +create 的信息「够又不够」:给了半截参数描述,模型觉得
够用就直接拼命令,不再打开文档。

  • 删掉「创建方式选择」整节(表格 + 两条 WARNING),下沉到 create.md, 由生成流程 Step 3 和核心规则 2 指向那份文档
  • Shortcuts 表 +create 行、核心规则 2 不再复述参数
  • Quick Reference 顶部说明参数以文档和 --help 为准,「新建 PPT」行补上 create.md
  • PPTX 一行改写为 drive +import 导入路径;create.md 里写明本命令不读 本地文件
  • create.md 增加「--slides 不接受的形态」对照表,并合并开头零散的 禁止/推荐/最稳/注意条目
  • @ 占位符统一写成 ,消除「--slides 支持 @ 路径」的歧义

Summary

Changes

  • Change 1
  • Change 2

Test Plan

  • Unit tests pass
  • Manual local verification confirms the lark-cli <domain> <command> flow works as expected

Related Issues

  • None

Summary by CodeRabbit

  • Documentation
    • Updated the create-from-scratch guidance to require submitting single-page slide XML directly, with an explicit prohibition on re-parsing/re-splitting full presentation XML for reuse.
    • Clarified that existing PPTX must be handled via the import workflow, not the create-from-zero command.
    • Strengthened warnings about shell parameter handling and non-atomic, per-page creation, including guidance for resuming after failures.
    • Refreshed quick-reference tables and improved shortcut wording, media upload/file_token placeholders, and troubleshooting cross-links.

R0bynZhu added 3 commits July 29, 2026 12:01
trace 里 +create 的三类高频错误(--yes、--name、--slides 塞文件路径)
共同点是调用前没读 lark-slides-create.md。原因不是文档缺内容,而是
SKILL.md 里 +create 的信息「够又不够」:给了半截参数描述,模型觉得
够用就直接拼命令,不再打开文档。

- 删掉「创建方式选择」整节(表格 + 两条 WARNING),下沉到 create.md,
  由生成流程 Step 3 和核心规则 2 指向那份文档
- Shortcuts 表 +create 行、核心规则 2 不再复述参数
- Quick Reference 顶部说明参数以文档和 --help 为准,「新建 PPT」行补上
  create.md
- PPTX 一行改写为 drive +import 导入路径;create.md 里写明本命令不读
  本地文件
- create.md 增加「--slides 不接受的形态」对照表,并合并开头零散的
  禁止/推荐/最稳/注意条目
- @ 占位符统一写成 <img src="@./path">,消除「--slides 支持 @ 路径」的歧义
@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Jul 29, 2026
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f069e41-8b3e-44e9-b32d-d0e85670c40c

📥 Commits

Reviewing files that changed from the base of the PR and between 2a2aa9b and 70901a7.

📒 Files selected for processing (1)
  • skills/lark-slides/SKILL.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • skills/lark-slides/SKILL.md

📝 Walkthrough

Walkthrough

Updated Lark Slides documentation to clarify slides +create creation modes, valid --slides payloads, PPTX import workflows, image handling, troubleshooting references, and append-page guidance.

Changes

Lark Slides guidance

Layer / File(s) Summary
Creation contract and input validation
skills/lark-slides/references/lark-slides-create.md
Documents page-level XML requirements, invalid --slides forms, PPTX import handling, shell parameter risks, and non-atomic creation with xml_presentation_id tracking.
SKILL workflow alignment
skills/lark-slides/SKILL.md
Updates quick reference mappings, creation workflow, image guidance, template handling, append-page jq guidance, shortcut wording, and core rules.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • larksuite/cli#450: Implements the image-upload and placeholder-replacement behavior documented by this change.
  • larksuite/cli#1720: Updates overlapping SKILL.md guidance for +create --slides, creation modes, and template editing.
  • larksuite/cli#1933: Updates related Slides creation and XML page-addition workflow documentation.

Suggested reviewers: fangshuyu-768

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description has the main points, but the required Summary, Changes, and Test Plan sections are left as placeholders. Fill in Summary, Changes, and Test Plan with concrete details and verification steps, and keep Related Issues as needed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the PR: moving +create parameter guidance into create.md and keeping SKILL.md as routing only.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-slides-create-doc-routing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.19%. Comparing base (358cd06) to head (70901a7).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2096      +/-   ##
==========================================
+ Coverage   75.16%   75.19%   +0.02%     
==========================================
  Files         912      914       +2     
  Lines       96475    96781     +306     
==========================================
+ Hits        72517    72776     +259     
- Misses      18381    18407      +26     
- Partials     5577     5598      +21     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@70901a75b7ab67e45de35df6adcd669fcaae736f

🧩 Skill update

npx skills add larksuite/cli#fix-slides-create-doc-routing -y -g

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/lark-slides/references/lark-slides-create.md`:
- Around line 18-22: Fix the MD028 warning in the admonition containing the
`--slides` guidance by removing the blank line between the two quoted sections
or prefixing that blank line with `>`. Keep the existing warning and important
content unchanged.
- Around line 6-8: Update the “只从零创建演示文稿,不读取本地文件” statement in the slides
+create documentation to clarify that presentation-file inputs such as PPTX
filenames are unsupported, while local image files referenced through <img
src="@./..."> remain supported for upload. Keep the existing PPTX import
workflow guidance unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0077f7f9-1f76-4dd6-a1a3-84c8e6443e03

📥 Commits

Reviewing files that changed from the base of the PR and between 59237f3 and 5a8b11a.

📒 Files selected for processing (2)
  • skills/lark-slides/SKILL.md
  • skills/lark-slides/references/lark-slides-create.md

Comment thread skills/lark-slides/references/lark-slides-create.md Outdated
Comment thread skills/lark-slides/references/lark-slides-create.md
原句「本命令只从零创建演示文稿,不读取本地文件」与本文档
「本地图片:@<path> 占位符」一节自相矛盾——@ 占位符恰恰会读
本地图片并自动上传。改为只否定「导入本地 PPT 文件的参数」,
不波及图片占位符能力。
@R0bynZhu
R0bynZhu force-pushed the fix-slides-create-doc-routing branch from fca681c to 2a2aa9b Compare July 29, 2026 08:57
生成流程 Step 3 和「执行前必做」的创建一行原来只指向
lark-slides-create.md,而两步创建的第二步用的是
xml_presentation.slide create,文档没被路由到,模型只能凭
记忆拼参数。
@R0bynZhu
R0bynZhu merged commit 29a6a7b into main Jul 29, 2026
37 of 42 checks passed
@R0bynZhu
R0bynZhu deleted the fix-slides-create-doc-routing branch July 29, 2026 12:50
@liangshuo-1 liangshuo-1 mentioned this pull request Jul 29, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants