docs: clarify native mindnote support boundary - #1569
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR rejects native ChangesMind Note routing and unsupported handling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shortcuts/doc/helpers_test.go`:
- Around line 51-55: The negative case in the helpers test currently only checks
the validation message string, so update the assertion in the relevant test case
to verify the typed validation error shape instead. Use the existing error
helpers and `errors.As`/`errs.ProblemOf` in `helpers_test.go` to assert the
expected category, subtype, and `Param` for the native Mind Note URL case, while
still preserving the cause.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6d50b9d6-6972-49cd-9db1-c76be3d94e05
📒 Files selected for processing (5)
shortcuts/doc/helpers.goshortcuts/doc/helpers_test.goskills/lark-doc/SKILL.mdskills/lark-drive/SKILL.mdskills/lark-whiteboard/SKILL.md
…rt-boundary # Conflicts: # skills/lark-doc/SKILL.md
|
Confirmed this PR is obsolete now. Main already documents and routes existing Mindnote operations through |
Summary
Clarify that native Mind Note URLs are not supported by the docs/whiteboard content shortcuts, and guide agents toward Drive-only operations for supported metadata, permission, and organization tasks.
Changes
docs +fetchvalidation message for/mindnote/URLs instead of the generic unsupported document URL text.parseDocumentReftests.lark-doc,lark-drive, andlark-whiteboardskill boundaries so agents do not route native Mind Note content requests to Docx or whiteboard flows.Test Plan
GOPROXY=https://goproxy.cn,direct go test ./shortcuts/doc -run TestParseDocumentRef -count=1GOPROXY=https://goproxy.cn,direct go test ./shortcuts/doc -count=1git diff --checklark-cli <domain> <command>flow works as expected (not run; this change is limited to parser validation text and skill documentation)Related Issues
Summary by CodeRabbit
Bug Fixes
/mindnote/…) and stops them from being handled as whiteboard/Docx content.Documentation
lark-doc,lark-drive, andlark-whiteboardscope docs to explicitly exclude native Mind Note content reading/node editing and clarify/mindnote/routing.Tests
/mindnote/…parsing, including verification of structured validation-error details.