docs(lark-slides): tighten SKILL.md routing and trim always-loaded content - #1169
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdated ChangesLark Slides Documentation Refinement
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-slides/references/lark-slides-permissions.md`:
- Line 3: Update the remediation instructions for missing scopes: replace the
user identity command suggestion `auth login --domain slides` with the correct
CLI usage that supplies the missing scopes, e.g. `lark-cli auth login --scope
"<missing scopes>"` (or `auth login --scope "<missing scopes>"` if using local
CLI shorthand) so it matches the missing-scope handling referenced in SKILL.md;
ensure the text around the `user 身份` guidance and the `bot 身份` guidance remains
consistent with this corrected flag usage.
- Line 9: Update the table row for the `slides +replace-slide` shortcut to
include the missing scope `slides:presentation:write_only` alongside
`slides:presentation:update` and `wiki:node:read` so the documented scopes match
the actual shortcut declaration and prevent preflight auth failures; locate the
entry referencing "`slides +replace-slide`" in lark-slides-permissions.md and
append `slides:presentation:write_only` to the listed scopes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0c4bbb3e-3aa7-4b0f-8eaf-622633bba3bd
📒 Files selected for processing (3)
skills/lark-slides/SKILL.mdskills/lark-slides/references/lark-slides-permissions.mdskills/lark-slides/references/visual-planning.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1169 +/- ##
==========================================
+ Coverage 70.33% 70.39% +0.06%
==========================================
Files 672 677 +5
Lines 65322 65599 +277
==========================================
+ Hits 45941 46176 +235
- Misses 15728 15757 +29
- Partials 3653 3666 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@4ee05ce448f94d01f98934934e6deb1cd745cd05🧩 Skill updatenpx skills add larksuite/cli#optimize/lark-slides-skill -y -g |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-slides/SKILL.md`:
- Around line 213-214: The doc uses dot notation
`xml_presentation.slide.create/delete/get/replace` which conflicts with later
CLI-style examples; update the mention to the space-separated CLI-style form
`xml_presentation.slide create/delete/get/replace` (and similarly change
`xml_presentations.get` to `xml_presentations get` where appropriate) so it
matches the `lark-cli slides <resource> <method>` format used elsewhere in the
file and avoids implying a single command path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 203010bd-bd81-465b-b70a-10ec3d2133a0
📒 Files selected for processing (1)
skills/lark-slides/SKILL.md
a633ada to
d36b62c
Compare
|
已 rebase 到最新 main(force-push,历史重写)。本次更新:
|
d36b62c to
eaa779e
Compare
…iteboard Land the high-value, low-risk items from the skill-quality audit; SKILL.md only. - description: drop the '接口通过 XML 协议通信' impl detail; append a 不负责 out-of-scope clause so 'make a deck' / 'draw a diagram' stop mis-routing. - replace the 权限速查 scope table with a ## 不在本 skill 范围 routing table (doc / whiteboard / drive / sheets / base). - reconcile the whiteboard boundary with the in-slide <whiteboard> element (added on main, #1029): lark-whiteboard owns only standalone whiteboard objects in cloud docs; flow/architecture diagrams drawn inside a slide stay in this skill via <whiteboard>. Clarified in description and out-of-scope note. - defer auth / permissions / global params to lark-shared as single source. - move native-API resource hint into prose; reword schema reminder; move the 'schema is source of truth' note next to 核心规则. Deliberately not adopted: moving Design Ideas out of the body, relocating the wiki-token section, dropping the native-API schema guardrail, and the bulk lark-slides- reference rename.
eaa779e to
4ee05ce
Compare
…iteboard (#1169) Land the high-value, low-risk items from the skill-quality audit; SKILL.md only. - description: drop the '接口通过 XML 协议通信' impl detail; append a 不负责 out-of-scope clause so 'make a deck' / 'draw a diagram' stop mis-routing. - replace the 权限速查 scope table with a ## 不在本 skill 范围 routing table (doc / whiteboard / drive / sheets / base). - reconcile the whiteboard boundary with the in-slide <whiteboard> element (added on main, #1029): lark-whiteboard owns only standalone whiteboard objects in cloud docs; flow/architecture diagrams drawn inside a slide stay in this skill via <whiteboard>. Clarified in description and out-of-scope note. - defer auth / permissions / global params to lark-shared as single source. - move native-API resource hint into prose; reword schema reminder; move the 'schema is source of truth' note next to 核心规则. Deliberately not adopted: moving Design Ideas out of the body, relocating the wiki-token section, dropping the native-API schema guardrail, and the bulk lark-slides- reference rename.
Background
Source: the CCM skill-quality audit doc (wiki), which raised 10 issues for lark-slides. After review this PR lands only the high-value, low-risk routing/boundary fixes and deliberately pushes back on the more aggressive structural suggestions. The net change is intentionally small:
SKILL.mdonly (15 insertions / 15 deletions).Changes (all in
SKILL.md)接口通过 XML 协议通信; append a不负责:...out-of-scope clause so "make a deck" / "draw a diagram" no longer mis-route to lark-doc / lark-whiteboard权限速查table with a## 不在本 skill 范围routing table (doc / whiteboard / drive / sheets / base)<whiteboard>(surfaced by the rebase)<whiteboard>element. Clarified in both the description and the out-of-scope noteDeliberately not adopted / reverted
These were considered and intentionally left as-is (see the revert commits in history):
Wiki 链接特殊处理section stays; native-API callers still need that manual step.lark-slides-prefix — not done. Purely cosmetic, touches every link with breakage risk for marginal benefit. (Audit premise was also partly wrong: the "loose" files are reachable transitively via the CRITICALxml-schema-quick-ref.md.)Verification
<whiteboard>row and the out-of-scope table after the rebase.