Repository navigation
fix(agent-v2): open per-message agent log modal from the Logs page - #44802
Open
wch243294382 wants to merge 1 commit into
Open
wch243294382 wants to merge 1 commit into
wch243294382 wants to merge 1 commit into
Conversation
The Agent detail Logs page rendered Chat without an onOpenLog handler, so the per-message log icon never appeared and there was no way to inspect a message trace from the Logs page. Fetch the agent backing_app_id (runtime agent app used for chat/log/monitoring) and mount AgentLogModal on selection; closing clears the local state. Coexists with the tracing ExternalTraceRow footer (langgenius#44186). Closes langgenius#40761
github-actions
Bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40761
Root cause
The Agent detail Logs page mounts
log-detail-panel.tsx, which renders<Chat>without anonOpenLoghandler. As a result the per-message log icon never appears, so there is no way to inspect a single message's trace from the Logs page.Fix
Frontend-only, no backend change:
backing_app_id(the runtime Agent App used for chat/log/monitoring) viaconsoleQuery.agent.byAgentId.getonOpenLogto a localselectedLogItemstate and mountAgentLogModalon selectionKeeps the tracing
ExternalTraceRowfooter introduced in #44186, and the test follows the behavioralwithConsoleResponsesstyle from #44260.Test
web/features/agent-v2/agent-detail/logs/__tests__/log-detail-panel.spec.tsx— added "opens the agent log modal for a message and closes it".