Skip to content

fix(web): keep hourly runs on the right date at month end - #43925

Merged
crazywoola merged 2 commits into
langgenius:mainfrom
JHC56:fix/hourly-month-end
Oct 13, 2026
Merged

crazywoola merged 2 commits into
langgenius:mainfrom
JHC56:fix/hourly-month-end

Conversation

@JHC56

@JHC56 JHC56 commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #43923

In visual Hourly mode, the next run list skipped a month after midnight on the last day of a month (for example "October 31" right after September 30 11:00 PM). setHours already rolls into the next day, month and year, so the extra overflow block is removed. Added tests for a month end and for New Year.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've verified the change and added or updated tests where meaningful regression risk justifies coverage.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and vp staged (frontend) to appease the lint gods

@JHC56
JHC56 requested review from iamjoel and zxhlyh as code owners October 12, 2026 06:39
@ghfind-review ghfind-review Bot added the review: medium ghfind author score; see https://ghfind.com label Oct 12, 2026
@github-actions github-actions Bot added size:M This PR changes 30-99 lines, ignoring generated files. web This relates to changes on the web. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 12, 2026
@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.83%. Comparing base (d562cc0) to head (f908065).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #43925   +/-   ##
=======================================
  Coverage   88.83%   88.83%           
=======================================
  Files        5321     5322    +1     
  Lines      329271   329258   -13     
  Branches    65972    65967    -5     
=======================================
+ Hits       292497   292500    +3     
+ Misses      31552    31536   -16     
  Partials     5222     5222           
Flag Coverage Δ
dify-ui 91.97% <ø> (+0.05%) ⬆️
web 89.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crazywoola
crazywoola added this pull request to the merge queue Oct 13, 2026
Merged via the queue into langgenius:main with commit cc4aaeb Oct 13, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review: medium ghfind author score; see https://ghfind.com web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schedule Trigger hourly list skips a month at month end

2 participants