Repository navigation
fix(web): keep hourly runs on the right date at month end - #43925
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43925 +/- ##
=======================================
Coverage 88.83% 88.83%
=======================================
Files 5321 5322 +1
Lines 329271 329258 -13
Branches 65972 65967 -5
=======================================
+ Hits 292497 292500 +3
+ Misses 31552 31536 -16
Partials 5222 5222
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 12, 2026
crazywoola
approved these changes
Oct 13, 2026
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #43923
In visual Hourly mode, the next run list skipped a month after midnight on the last day of a month (for example "October 31" right after September 30 11:00 PM).
setHoursalready rolls into the next day, month and year, so the extra overflow block is removed. Added tests for a month end and for New Year.Checklist
make lint && make type-check(backend) andvp staged(frontend) to appease the lint gods