Repository navigation
refactor(web): remove success toasts for results visible in place - #43801
Merged
Merged
Conversation
Drop the success toast after a switch, select, or rating control changes a value the control already shows, and move copy feedback for chat and saved-result icon buttons into the button through CopyFeedback. Record the toast usage rule in web/docs/toasts.md.
lyzno1
requested review from
CodingOnStar,
JzoNgKVO,
WTW0313,
hyoban,
iamjoel and
zxhlyh
as code owners
October 10, 2026 04:22
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43801 +/- ##
==========================================
- Coverage 88.71% 88.71% -0.01%
==========================================
Files 5208 5208
Lines 327159 327136 -23
Branches 65511 65512 +1
==========================================
- Hits 290248 290225 -23
Misses 31668 31668
Partials 5243 5243
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lyzno1
enabled auto-merge
October 10, 2026 04:25
6 tasks done
iamjoel
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #43802
A toast should report a result the user cannot see where they acted. Many success toasts in
web/fire from a mutation callback even though the control that triggered the mutation already shows the new value, so the toast only adds noise. This PR removes the clearest cases and records the rule.Success toasts removed where the control already shows the result
Copy feedback moved into the button
CopyFeedback: the icon, tooltip, and accessible name change to the copied state instead of a "Copied successfully" toast. This adds a tooltip to those three buttons.Rule
web/docs/toasts.mddefines when a toast is appropriate for success and error feedback, andweb/AGENTS.mdlinks to it.how-to-write-componentandfrontend-code-reviewreferences carry the principle only.Not in this PR
CopyFeedback(different variant or size, a disabled state, lazily computed content, text buttons, menu items) and the image preview copy button, whose copied state is colour-only and never resets.api.actionSuccess,actionMsg.modifiedSuccessfully,api.success) stay until their remaining call sites are migrated.From Claude Code