Repository navigation
test(api): enable strict pagination test types - #43432
Open
kr1shna-exe wants to merge 2 commits into
Open
kr1shna-exe wants to merge 2 commits into
kr1shna-exe wants to merge 2 commits into
Conversation
Contributor
Pyrefly Type Coverage
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43432 +/- ##
=======================================
Coverage 89.82% 89.82%
=======================================
Files 6244 6244
Lines 397256 397256
Branches 80000 80000
=======================================
Hits 356849 356849
Misses 34111 34111
Partials 6296 6296
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 18, 2026
asukaminato0721
enabled auto-merge
October 30, 2026 14:18
asukaminato0721
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #36288.
The pagination unit tests are excluded from strict Pyrefly checking and produce 24 diagnostics when checked directly. This enables strict checking for that file.
What changed
PaginatedResult[object]for empty containers.libs/test_pagination.pyfrom the strict-check exclusions.Existing test inputs and assertions are unchanged. This covers one file in the broader issue.
Verification
uv run --project api pyrefly check api/tests/unit_tests/libs/test_pagination.py: 24 diagnostics before; 0 after.make test TARGET_TESTS=./api/tests/unit_tests/libs/test_pagination.py: 24 passed.make lint && make type-check: passed.git diff --check: passed.Screenshots
Not applicable: test annotations and type-check configuration only.
Checklist