Repository navigation
fix(knowledge): show paused and deleted golden question sources - #43082
Merged
JohnJyong merged 2 commits intoSep 28, 2026
Merged
Conversation
JohnJyong
requested review from
QuantumGhost,
crazywoola,
iamjoel,
laipz8200 and
lyzno1
as code owners
September 28, 2026 16:04
github-actions
Bot
added
size:L
ghfind-review
Bot
added
the
review: high
Contributor
Pyrefly Type Coverage
|
github-actions
Bot
added
the
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Golden Questions backed by a disabled document now display “Paused”, with an explanation that evaluation resumes when the document is enabled. Questions retained after source deletion display a source-deleted explanation and can be rebound using the existing editor. These states follow KnowledgeFS source availability, so existing evaluation selection counts exclude paused questions.
Update the DTO, regenerate TypeScript/Zod contracts, API docs and translation types, and add localized status explanations in every supported locale. The information popup fits the existing fixed-height table rows and supports keyboard access. Refresh cached Golden Questions for the current space after single/bulk document availability changes and when background deletion finishes.
Validation: full repository static check passed (0 errors); 101 product DTO tests and 397 document/quality-page tests passed; Python type checking and lint passed; all locale keys validated. Companion backend: https://github.com/langgenius/knowledge-fs/pull/54. This PR targets the existing dev deployment branch; verify both revisions in dev after deployment.